-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update commit message format docs (refs #14231) #15200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* `fix` - for a bug fix. | ||
* `feat` - either for a backwards-compatible enhancement or for a rule change that adds reported problems. | ||
* `fix!` - for a backwards-incompatible bug fix. | ||
* `feat!:` - for a backwards-incompatible enhancement or feature. | ||
* `docs` - changes to documentation only. | ||
* `chore` - for changes that aren't user-facing. | ||
* `build` - changes to build process only. | ||
* `refactor` - a change that doesn't affect APIs or user experience. | ||
* `test` - just changes to test files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want this list to match eslint/eslint-github-bot#158, then ci
and perf
are missing.
Merging now so that this change gets published on eslint.org, as we're switching to conventional commits after this release. We can later discuss if some tags are missing. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Updated the docs to explain that we are using conventional commits going forward.
Is there anything you'd like reviewers to focus on?
Are the docs clear?